Redirect forceVerify email address action back to edit/view (CFM-14) #418
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benno
reviewed
Jun 17, 2026
| @@ -560,7 +560,7 @@ public function generateRedirect($entity) { | |||
| return $this->redirect(['action' => 'deleted']); | |||
| } elseif($redirectGoal == 'self' | |||
| && $entity | |||
| && in_array($this->request->getParam('action'), ['add', 'copy', 'edit', 'unfreeze'])) { | |||
| && in_array($this->request->getParam('action'), ['add', 'copy', 'edit', 'unfreeze', 'forceVerify'])) { | |||
Contributor
There was a problem hiding this comment.
Unlike the other actions, forceVerify is specific to EmailAddress and so probably shouldn't be hardcoded into this list.
We probably need something like PrimaryLinkTrait's allowLookupPrimaryLink(), etc, except this probably belongs in TableMetaTrait instead. It should default to the four standard actions, then EmailAddressesTable could add forceVerify as an approved action via getSelfRedirectGoals() or whatever.
Contributor
|
Following our discussion, I refactored this and committed it as a17494d. |
Sign in
to join this conversation on GitHub.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.